Dennis-Mircea opened a new pull request, #1141:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1141
## What is the purpose of the change
The autoscaler option `AutoScalerOptions.FLINK_CLIENT_TIMEOUT`
(`job.autoscaler.flink.rest-client.timeout`, fallback
`kubernetes.operator.flink.rest-client.timeout`, default `10s`) had no effect
inside the Kubernetes operator: when the operator builds the autoscaler context
in `FlinkResourceContext.createJobAutoScalerContext`, it ingests the resource's
effective deploy config (which already contains any user-set
`job.autoscaler.flink.rest-client.timeout`) and then **unconditionally**
overwrote `AutoScalerOptions.FLINK_CLIENT_TIMEOUT` with the operator-level
`OPERATOR_FLINK_CLIENT_TIMEOUT` (`kubernetes.operator.flink.client.timeout`).
As a result a user's explicit autoscaler timeout was always clobbered, so the
documented option was a no-op in operator mode (it works in the standalone
autoscaler, which has no operator config to override it).
This PR makes the operator timeout a default rather than an unconditional
override, so an explicitly configured autoscaler timeout is honored.
## Brief change log
- `FlinkResourceContext.createJobAutoScalerContext`: apply the operator
client timeout to `AutoScalerOptions.FLINK_CLIENT_TIMEOUT` only when the user
has not explicitly set it, guarded with
`conf.contains(AutoScalerOptions.FLINK_CLIENT_TIMEOUT)`, matching the existing
`setDefaultConf` pattern. The operator timeout remains the default (so the
autoscaler stays consistent with the rest of the operator's Flink REST
interactions), while an explicit `job.autoscaler.flink.rest-client.timeout` is
respected.
## Verifying this change
This change can be verified with the new and existing unit tests + some
existing examples.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changes to the `CustomResourceDescriptors`:
no
- Core observer or reconciler logic that is regularly executed: yes
(autoscaler context creation in the reconcile loop)
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
