gyfora commented on code in PR #1082:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1082#discussion_r3441665682
##########
helm/flink-kubernetes-operator/crds/flinkbluegreendeployments.flink.apache.org-v1.yml:
##########
@@ -10947,4 +10999,6 @@ spec:
served: true
storage: true
subresources:
+ scale:
+ specReplicasPath: ".spec.template.spec.taskManager.replicas"
Review Comment:
I think there is some logic to explicitly remove this
##########
e2e-tests/data/resource-requirements-cr.yaml:
##########
@@ -0,0 +1,73 @@
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# limitations under the License.
+################################################################################
+
+apiVersion: flink.apache.org/v1beta1
+kind: FlinkDeployment
+metadata:
+ namespace: default
+ name: flink-example-resource-requirements
+spec:
+ image: flink:1.20
+ flinkVersion: v1_20
+ flinkConfiguration:
+ taskmanager.numberOfTaskSlots: "2"
+ kubernetes.operator.snapshot.resource.enabled: "false"
+ serviceAccount: flink
Review Comment:
Instead if introducing a new test, I suggest updating the existing tests to
use the new syntax (this is going to be the way forward). We should keep a
single e2e that uses the old syntax (not necessary to add a separate test case)
##########
helm/flink-kubernetes-operator/crds/flinkbluegreendeployments.flink.apache.org-v1.yml:
##########
@@ -10947,4 +10999,6 @@ spec:
served: true
storage: true
subresources:
+ scale:
+ specReplicasPath: ".spec.template.spec.taskManager.replicas"
Review Comment:
why this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
