Dennis-Mircea opened a new pull request, #1142:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1142
## What is the purpose of the change
`Diffable` is a marker interface that `ReflectiveDiffBuilder` consults only
to decide whether to recurse into a **nested** field
(`Diffable.class.isAssignableFrom(field.getType())`). The root object of a diff
is always processed unconditionally, so a root type's `Diffable`-ness is never
checked.
This change removes those unused markers so `Diffable` only appears where
the engine actually uses it.
## Brief change log
- Removed `implements Diffable<...>` and the now-unused `Diffable` import
from `AbstractFlinkSpec`.
- Removed the same from `FlinkStateSnapshotSpec` and
`FlinkStateSnapshotStatus`.
- Kept `Diffable` on `JobSpec` and `TaskManagerSpec`, the nested fields
the diff engine genuinely recurses into.
## Verifying this change
This change is already covered by existing tests, all of them passing
already with this new change.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changes to the `CustomResourceDescriptors`:
no (`Diffable` is an internal marker interface, not serialized; no CRD/schema
impact)
- Core observer or reconciler logic that is regularly executed: no (diff
behavior is unchanged)
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
