vsantwana opened a new pull request, #1143:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1143
## What is the purpose of the change
The `flinkbluegreendeployments` CRD must not carry a `scale` subresource: it
has no `statusReplicasPath` and is rejected by the API server (`helm install`
fails with `spec.subresources.scale.statusReplicasPath: Required value`).
`RemoveScaleSubResource` strips that block, but it was bound to the
**`package`** phase, while `crd-generator:generate` and the copy of generated
CRDs into `helm/crds` (added when CRD auto-generation was wired up in #1140)
run in **`process-classes`**. A build that stops before `package` -- e.g. `mvn
compile` / `mvn test-compile` -- therefore regenerates and copies the
*un-stripped* CRD into the committed chart without ever stripping it, leaving
an invalid `scale` block that breaks `helm install`.
## Brief change log
- Bind the `flinkbgdeployments-remove-scale-subresource` execution to
`process-classes` (after `crd-generator:generate` and `copy-resources`, which
are ordered first by plugin declaration order) instead of `package`, so every
build that regenerates the CRDs also strips the B/G scale subresource.
## Verifying this change
On a clean checkout, `mvn -pl flink-kubernetes-operator-api test-compile`
now leaves `helm/.../flinkbluegreendeployments...yml` unchanged (the
regenerated scale block is stripped in `process-classes`). Before this change,
the same partial build re-introduced the invalid `scale` block.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changes to the `CustomResourceDescriptors`:
no (build-only; keeps the committed CRD correct)
- Core observer or reconciler logic that is regularly executed: no
## Documentation
- Does this pull request introduce a new feature? no
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
