gyfora commented on code in PR #1085:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1085#discussion_r3443553704
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java:
##########
@@ -469,6 +475,11 @@ private boolean checkIfBlockedAndTriggerScalingEvent(
Instant now) {
var scaleEnabled = conf.get(SCALING_ENABLED);
var isExcluded = CalendarUtils.inExcludedPeriods(conf, now);
+ if (scaleEnabled && !isExcluded) {
+ // Not blocked. The scaling report is emitted later, once the
decision is final
+ // (after memory tuning, the max-resource check, and the custom
scaling executors).
+ return false;
Review Comment:
sorry maybe it's a stopid question but why do we return early if we are not
blocked? wouldn't this prevent us from ever reaching
"autoScalerEventHandler.handleScalingEvent" in the normal scaling case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
