Shekharrajak commented on code in PR #271: URL: https://github.com/apache/flink-connector-kafka/pull/271#discussion_r3445484144
########## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/share/ShareAckCommittable.java: ########## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.kafka.share; + +import org.apache.flink.annotation.Internal; + +import java.util.Objects; + +@Internal +public class ShareAckCommittable { + + private final long checkpointId; + private final String transactionalId; + private final long transactionOwnerId; + private final short transactionOwnerEpoch; + private final String groupId; + private final int sourceSubtaskId; + + public ShareAckCommittable( + long checkpointId, + String transactionalId, + long transactionOwnerId, + short transactionOwnerEpoch, + String groupId, + int sourceSubtaskId) { + this.checkpointId = checkpointId; + this.transactionalId = transactionalId; + this.transactionOwnerId = transactionOwnerId; + this.transactionOwnerEpoch = transactionOwnerEpoch; + this.groupId = groupId; + this.sourceSubtaskId = sourceSubtaskId; + } + + public long getCheckpointId() { + return checkpointId; + } + + public String getTransactionalId() { + return transactionalId; + } + + public long getTransactionOwnerId() { + return transactionOwnerId; Review Comment: transactionOwnerId , transactionOwner epoch is actually producer id and epoch - we are trying to decouple the txn ownership from producer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
