weiqingy commented on code in PR #28484:
URL: https://github.com/apache/flink/pull/28484#discussion_r3447997281
##########
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/TaskMailboxImpl.java:
##########
@@ -247,6 +248,7 @@ private void moveUrgentMailsToBatchIfNeeded(boolean
onlyMoveUrgentMails) {
}
}
+ final boolean shouldOnlyMoveUrgentMails = onlyMoveUrgentMails &&
!isBatchEmpty;
Review Comment:
Perfect — sitting right above the assignment, the reasoning is impossible to
miss now. That was my only open item, and the fix itself stays nicely contained
to the one boolean. LGTM. I'll leave the final call to the maintainers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
