snuyanzin commented on code in PR #28290:
URL: https://github.com/apache/flink/pull/28290#discussion_r3448678479
##########
flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql/type/SqlTypeFactoryImpl.java:
##########
@@ -39,10 +40,8 @@
* <p>FLINK modifications are at lines
*
* <ol>
- * <li>Should be removed after fixing CALCITE-6342: Lines 113-115
- * <li>Added in FLINK-39695 (backport of CALCITE-6764): Lines 243 ~ 266
- * <li>Should be removed after fix of FLINK-31350: Lines 527-539.
- * <li>Should be removed after fixing CALCITE-6342: Lines 606-618
+ * <li>Should be removed after fixing CALCITE-6342: Lines 527-529.
Review Comment:
sync with Calcite
##########
flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java:
##########
@@ -89,7 +89,7 @@ public abstract class SqlTypeUtil {
* same charset and collation of same charset
*/
public static boolean isCharTypeComparable(List<RelDataType> argTypes) {
- assert argTypes != null;
+ requireNonNull(argTypes, "argTypes");
Review Comment:
sync with Calcite
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
