swatiksi273-ksolves commented on code in PR #1139:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1139#discussion_r3450011594
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/metrics/ScalingMetrics.java:
##########
@@ -83,6 +83,15 @@ public static void computeDataRateMetrics(
var isSource = topology.isSource(jobVertexID);
var ioMetrics = topology.get(jobVertexID).getIoMetrics();
+ if (!ioMetrics.isMetricsComplete()) {
+ LOG.warn(
+ "Incomplete IO metrics for vertex {}, skipping scaling
decision to avoid incorrect scale down.",
+ jobVertexID);
+ scalingMetrics.put(ScalingMetric.NUM_RECORDS_IN, Double.NaN);
+ scalingMetrics.put(ScalingMetric.NUM_RECORDS_OUT, Double.NaN);
Review Comment:
Hi @Dennis-Mircea, I wanted to follow up on this PR.
As mentioned, the fix has been narrowed down strictly to
ScalingMetricCollector.java per your suggestions. Whenever you have some time,
please let me know if the current implementation looks good to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
