lucasgameiroborges commented on PR #1138: URL: https://github.com/apache/flink-kubernetes-operator/pull/1138#issuecomment-4778581415
Thank your for taking the time to review my change @Dennis-Mircea ! Answering to your points: I added the minimum steps to reproduce the issue on the ticket description in JIRA, and also on PR description: https://issues.apache.org/jira/browse/FLINK-39953 Regarding double logging: I removed the error logging from `deleteBlocking` before rethrow. However, I kept the warning log on the `NativeFlinkService` side since the scale-down of JM pods to 0 should not block the following deletions. Let me know if you agree. Regarding Standalone part: If I understand correctly, there's nothing to patch there. `StandaloneFlinkService.deleteClusterInternal` calls `deleteDeploymentBlocking` from the abstract which will throw the timeout exception as per the fix. It calls it twice to issue "mandatory" deletions of JMs and TMs, so no reason to catch and log warnings here. Happy to address any other concerns that appear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
