och5351 commented on PR #28481: URL: https://github.com/apache/flink/pull/28481#issuecomment-4786321783
> Thanks @ocb3916 @och5351 @spuru9 > > IIUC, The semantic of the deleted class `SynchronousComponentMainThreadExecutor` is same to the `NoMainThreadCheckComponentMainThreadExecutor` ? > > If so, this change would theoretically be unable to fix the issue, wouldn't it? > > Pls correct me if I'm wrong. Hi, @RocMarshal ! When I first opened this PR as a Jira ticket, I mistakenly categorized it as a flaky test issue. Looking at it again now, I see that the implementations of `SynchronousComponentMainThreadExecutor` and `NoMainThreadCheckComponentMainThreadExecutor` are identical. Additionally, the comments clearly state that this implementation was created specifically to avoid forMainThread(), which was the root cause of the flaky test. So it appears my initial misunderstanding was incorrect. Nevertheless, the legitimate reason this PR should be merged is to eliminate the duplicate class. cc. @spuru9 @ocb3916 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
