snuyanzin commented on code in PR #28497:
URL: https://github.com/apache/flink/pull/28497#discussion_r3464894133
##########
flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileProcessingITCase.java:
##########
@@ -263,7 +263,7 @@ public void close() {
for (String line : cntnt) {
cntntStr.append(line);
}
- Assert.assertEquals(expectedContents.get(fileIdx),
cntntStr.toString());
+
assertThat(cntntStr).hasToString(expectedContents.get(fileIdx));
Review Comment:
am I right that these 7 lines could be replaced with something like
```java
List<String> cntnt = new ArrayList<>(actualContent.get(fileIdx));
cntnt.sort(comparator);
Assert.assertEquals(expectedContents.get(fileIdx),
String.join("", cntnt));
```
##########
flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileProcessingITCase.java:
##########
@@ -263,7 +263,7 @@ public void close() {
for (String line : cntnt) {
cntntStr.append(line);
}
- Assert.assertEquals(expectedContents.get(fileIdx),
cntntStr.toString());
+
assertThat(cntntStr).hasToString(expectedContents.get(fileIdx));
Review Comment:
am I right that these 7 lines could be replaced with something like
```java
List<String> cntnt = new ArrayList<>(actualContent.get(fileIdx));
cntnt.sort(comparator);
Assert.assertEquals(expectedContents.get(fileIdx), String.join("", cntnt));
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
