hiSandog commented on PR #28519: URL: https://github.com/apache/flink/pull/28519#issuecomment-4807478501
The approach looks sound — overriding `getJob()` in `WaitingForResources` to carry checkpoint stats from `previousExecutionGraph` into the archived graph is a clean, localized fix. The `withCheckpointStatsSnapshot` copy method on `ArchivedExecutionGraph` is straightforward and avoids mutating shared state. One minor observation: the second test (`testGetJobWithoutPreviousExecutionGraphReturnsNullCheckpointStats`) only asserts that `archivedGraph` is not null, but doesn't explicitly verify that `getCheckpointStatsSnapshot()` is null. Adding an explicit `assertThat(archivedGraph.getCheckpointStatsSnapshot()).isNull()` would make the negative case more robust against future refactors. CI is green and the change is well-scoped — nice first contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
