davidradl commented on code in PR #28546:
URL: https://github.com/apache/flink/pull/28546#discussion_r3479995979
##########
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonParserToRowDataConverters.java:
##########
@@ -278,6 +279,17 @@ private TimestampData convertToTimestamp(JsonParser jp)
throws IOException {
case ISO_8601:
parsedTimestamp = ISO8601_TIMESTAMP_FORMAT.parse(jp.getText());
break;
+ case ISO_8601_WITH_OFFSET:
Review Comment:
my AI says
For DST: Document that this format preserves the explicit offset only, not
the timezone. Users needing DST-aware handling should use
TIMESTAMP_WITH_LOCAL_TIMEZONE with a proper timezone ID (e.g.,
America/New_York), not just offsets.
For Half-Hour Timezones: Add comprehensive tests:
root.put("timestamp_india", "1990-10-14T12:12:43.123+05:30");
root.put("timestamp_nepal", "1990-10-14T12:12:43.123+05:45");
Consider: Whether output should preserve the original offset instead of
always converting to UTC. Current behavior may surprise users expecting offset
preservation.
Documentation: Clearly state that this format converts all timestamps to UTC
offset (+00:00) on output, regardless of input offset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
