davidradl commented on code in PR #28516:
URL: https://github.com/apache/flink/pull/28516#discussion_r3480052905
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/optimize/program/FlinkRecomputeStatisticsProgram.java:
##########
@@ -181,8 +181,10 @@ private TableStats getPartitionsTableStats(
for (CatalogPartitionSpec partitionSpec :
catalogPartitionSpecs) {
partitionList.add(partitionSpec.getPartitionSpec());
}
- } catch (TableNotExistException | TableNotPartitionedException
e) {
+ } catch (TableNotExistException e) {
throw new TableException("Table not exists!", e);
+ } catch (TableNotPartitionedException e) {
+ return TableStats.UNKNOWN;
Review Comment:
I am unsure what the impact is of this change. Is it that Flink does not
support somehting in Hive and we need to indicate it is unknown. If that is the
case, it would be worth raising a Jira to track this enhancement and refer to
the Jira number as a comment in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
