[
https://issues.apache.org/jira/browse/FLINK-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838835#comment-15838835
]
ASF GitHub Bot commented on FLINK-5608:
---------------------------------------
Github user rehevkor5 commented on the issue:
https://github.com/apache/flink/pull/3189
Thanks @uce that's helpful! Didn't think of putting screenshots in the PR.
@zentol The global job state counts didn't seem like the most important
thing to show when the browser is narrow, given that this view is about a
particular job. So, I added these CSS classes to it ".hidden-xs .hidden-sm
.hidden-md" the behavior of which is described on
http://getbootstrap.com/css/#responsive-utilities I am not sure what width @uce
used for the "wide" screenshots, but it probably was less than 1200px,
otherwise it would show up. I can remove the ".hidden-md" class if you want it
to show up in the 992px to 1200px range, too... however it does make it more
likely for the other more job-specific elements (start/end, duration) to wrap &
get lost. Perhaps it would be a good idea to reorder the elements? Put
start/end & duration first, and overall job stats last so that it's the first
one to wrap? Let me know if you have a preference.
> Cancel button not always visible
> --------------------------------
>
> Key: FLINK-5608
> URL: https://issues.apache.org/jira/browse/FLINK-5608
> Project: Flink
> Issue Type: Bug
> Components: Webfrontend
> Affects Versions: 1.1.4
> Reporter: Shannon Carey
> Assignee: Shannon Carey
> Priority: Minor
>
> When the window is not wide enough, or when the job name is too long, the
> "Cancel" button in the Job view of the web UI is not visible because it is
> the first element that gets wrapped down and gets covered by the secondary
> navbar (the tabs). This causes us to often need to resize the browser wider
> than our monitor in order to use the cancel button.
> In general, the use of Bootstrap's ".navbar-fixed-top" is problematic if the
> content may wrap, especially if the content's horizontal width if not known &
> fixed. The ".navbar-fixed-top" uses fixed positioning, and therefore any
> unexpected change in height will result in overlap with the rest of the
> normal-flow content in the page. The Bootstrap docs explain this in their
> "Overflowing content" callout.
> I am submitting a PR which does not attempt to resolve all issues with the
> fixed navbar approach, but attempts to improve the situation by using less
> horizontal space and by altering the layout approach of the Cancel button.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
