wenjin272 commented on code in PR #835:
URL: https://github.com/apache/flink-agents/pull/835#discussion_r3490714780
##########
python/flink_agents/plan/agent_plan.py:
##########
@@ -280,6 +294,8 @@ def _get_actions(agent: Agent) -> List[Action]:
if marker is None:
continue
inner, listen_events, target = marker
+ if target is None:
+ _warn_if_action_returns_value(name, inner)
Review Comment:
I think we can move this validation to the initialize function of `Action`,
after the `self.exec.check_signature(Event, RunnerContext)`. Thus, we no longer
need to handle different action construction paths, such as `@action` and
`add_action`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
