cjohnson-confluent commented on code in PR #28555:
URL: https://github.com/apache/flink/pull/28555#discussion_r3493046904
##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java:
##########
@@ -1166,10 +1166,14 @@ void markFinished(Map<String, Accumulator<?, ?>>
userAccumulators, IOMetrics met
if (current == INITIALIZING || current == RUNNING || current ==
DEPLOYING) {
+ // Store metrics before the state transition so that listeners
+ // notified inside transitionState() can read them via
getIOMetrics().
+ // This matches the ordering already used by
completeCancelling().
+ updateAccumulatorsAndMetrics(userAccumulators, metrics);
+
if (transitionState(current, FINISHED)) {
Review Comment:
Yeah, that sounds good. I'll amend again in a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
