MartijnVisser commented on code in PR #28567: URL: https://github.com/apache/flink/pull/28567#discussion_r3493465176
########## flink-end-to-end-tests/README.md: ########## @@ -13,12 +13,13 @@ You can run all tests by executing $ FLINK_DIR=<flink dir> flink-end-to-end-tests/run-nightly-tests.sh ``` -where \<flink dir\> is a Flink distribution directory. +where \<flink dir\> is a Flink distribution directory, e.g. `build-target` after building Flink +from source, or the directory of an unpacked release. You can also run tests individually via ``` -$ FLINK_DIR=<flink dir> flink-end-to-end-tests/run-single-test.sh your_test.sh arg1 arg2 +$ FLINK_DIR=<flink dir> flink-end-to-end-tests/run-single-test.sh flink-end-to-end-tests/test-scripts/your_test.sh arg1 arg2 Review Comment: The reason I touched it: run_test (in `test-runner-common.sh`) executes the test-script path as-is from your current working directory. Since the example invokes `flink-end-to-end-tests/run-single-test.sh` from the repository root, a bare `your_test.sh` isn't found there. The contributor would have to be inside `flink-end-to-end-tests/`. I made it a full path to stay consistent with the concrete S3 examples I added just below it (which need to be copy-pasteable from the repo root). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
