Timm0 commented on code in PR #28585:
URL: https://github.com/apache/flink/pull/28585#discussion_r3498508997


##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/connectors/CollectDynamicSink.java:
##########
@@ -217,9 +217,14 @@ public RowDataToStringConverter 
getRowDataStringConverter() {
 
         @Override
         public boolean isFirstRowReady() {

Review Comment:
   Good point, I'll update the doc string there to indicate that a returned 
result from hasNext() is an indication that the first row is ready.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to