Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3031#discussion_r97757847
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
@@ -101,7 +101,7 @@
* The assigner is kept in serialized form, to deserialize it into
multiple copies */
private SerializedValue<AssignerWithPunctuatedWatermarks<T>>
punctuatedWatermarkAssigner;
- private transient ListState<Tuple2<KafkaTopicPartition, Long>>
offsetsStateForCheckpoint;
+ private transient ListState<Tuple2<KafkaTopicPartition, Tuple2<Long,
Long>>> offsetsAndWatermarksStateForCheckpoint;
--- End diff --
I think we should switch to have a specific checkpointed state object
instead of continuing to "extend" the original Tuple. This will also be helpful
for compatibility for any future changes to the checkpointed state.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
