[ https://issues.apache.org/jira/browse/FLINK-4616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15839321#comment-15839321 ]
ASF GitHub Bot commented on FLINK-4616: --------------------------------------- Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3031#discussion_r97935971 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/KafkaTopicPartitionStateWithPeriodicWatermarks.java --- @@ -61,6 +61,10 @@ public long getCurrentWatermarkTimestamp() { return partitionWatermark; } + void setCurrentWatermarkTimestamp(long watermarkTimestamp) { --- End diff -- The other methods seem to be `public` (although they can actually be package-private). Should we stay consistent with that here? > Kafka consumer doesn't store last emmited watermarks per partition in state > --------------------------------------------------------------------------- > > Key: FLINK-4616 > URL: https://issues.apache.org/jira/browse/FLINK-4616 > Project: Flink > Issue Type: Bug > Components: Kafka Connector > Affects Versions: 1.1.1 > Reporter: Yuri Makhno > Assignee: Roman Maier > > Kafka consumers stores in state only kafka offsets and doesn't store last > emmited watermarks, this may go to wrong state when checkpoint is restored: > Let's say our watermark is (timestamp - 10) and in case we have the following > messages queue results will be different after checkpoint restore and during > normal processing: > A(ts = 30) > B(ts = 35) > ------ checkpoint goes here > C(ts=15) -- this one should be filtered by next time window > D(ts=60) -- This message was sent by Atlassian JIRA (v6.3.4#6332)