bharathgunapati opened a new pull request, #50:
URL: https://github.com/apache/flink-connector-http/pull/50

   ## What is the purpose of the change
   
   The HTTP connector currently has no architecture tests, unlike most other 
Flink
   connectors (e.g. flink-connector-kafka, flink-connector-jdbc, 
flink-connector-aws),
   which enforce structural rules via the shared flink-architecture-tests 
framework
   (ArchUnit). This PR adds the standard Flink architecture tests to
   flink-connector-http so the connector is held to the same architectural 
guarantees
   and new violations are caught automatically in CI. As is conventional when
   introducing architecture tests (see FLINK-24138), existing violations are 
recorded
   in a frozen baseline rather than fixed here, keeping the change scoped to 
adding
   the tests.
   
   ## Brief change log
   
   - Add test-scoped flink-architecture-tests-test and 
flink-architecture-tests-production dependencies
   - Add ProductionCodeArchitectureTest and TestCodeArchitectureTest under 
org.apache.flink.architecture
   - Add archunit.properties with the standard freezing-store configuration 
(archRule.failOnEmptyShould=false for rules not applicable to this connector)
   - Commit the initial archunit-violations freezing store as a baseline
   
   ## Verifying this change
   
   This change is itself a set of architecture tests. It can be verified by 
running
   `mvn -pl flink-connector-http test 
-Dtest='ProductionCodeArchitectureTest,TestCodeArchitectureTest'`
   and confirming both pass against the committed baseline.
   
   ## Does this pull request potentially affect one of the following areas?
   
   - **Dependencies**: Yes — adds two test-only dependencies 
(flink-architecture-tests-test, flink-architecture-tests-production)
   - **Performance**: No
   - **Security**: No
   - **Breaking changes**: No — test-only; no production code or public API is 
changed
   
   ## Documentation
   
   Not applicable — this change adds internal test tooling only and introduces 
no user-facing feature or configuration.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to