gaborgsomogyi commented on code in PR #28590:
URL: https://github.com/apache/flink/pull/28590#discussion_r3510567051
##########
flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/api/filter/SavepointKeyFilter.java:
##########
@@ -111,9 +112,18 @@ static <K> SavepointKeyFilter<K> exact(K value) {
static <K extends Comparable<K>> SavepointKeyFilter<K> range(
@Nullable K lower, boolean lowerInclusive, @Nullable K upper,
boolean upperInclusive) {
- BoundInfo lowerBoundInfo = lower != null ? new BoundInfo(lower,
lowerInclusive) : null;
- BoundInfo upperBoundInfo = upper != null ? new BoundInfo(upper,
upperInclusive) : null;
- return new RangeKeyFilter<>(lowerBoundInfo, upperBoundInfo);
+ return range(lower, lowerInclusive, upper, upperInclusive,
Comparator.naturalOrder());
+ }
+
+ static <K> SavepointKeyFilter<K> range(
+ @Nullable K lower,
+ boolean lowerInclusive,
+ @Nullable K upper,
+ boolean upperInclusive,
+ Comparator<K> comparator) {
Review Comment:
Nice catch, fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
