zxs1633079383 commented on PR #870: URL: https://github.com/apache/flink-agents/pull/870#issuecomment-4902372656
Hi @weiqingy, just a gentle follow-up when you have a chance. I updated this PR in `e023346` to address the root correctness issue from your inline review: - Removed the Java `ThreadLocal` and Python `ContextVar` token-usage side channel. - Added a result-plus-usage path for embeddings while keeping the existing public `embed(...)` return types unchanged. - Moved metric recording to setup after a successful returned result. - Added regression coverage for provider-failure-then-success and Bedrock batch usage aggregation. The PR is currently clean and all checks are green. If you still see any correctness/API concerns, I am happy to iterate; otherwise I would appreciate another review when convenient. Thanks again for the detailed review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
