weiqingy opened a new pull request, #205: URL: https://github.com/apache/flink-connector-jdbc/pull/205
## What is the purpose of the change The `flink-connector-jdbc-backward-compatibility` module ships two files that are missing the Apache license header every other source file in the repository carries: - `flink-connector-jdbc-backward-compatibility/pom.xml` - `flink-connector-jdbc-backward-compatibility/src/test/java/org/apache/flink/connector/jdbc/backward/compatibility/DynamicTableSourceTest.java` Both files are included in the source release tarball (observed while verifying the `flink-connector-jdbc-4.1.0` RC3 source distribution; the same state is on `main`). The module's three sibling test files already carry the header. ## Why it isn't caught by CI The module is intentionally excluded from the parent pom's `<modules>` so it can be built standalone against multiple Flink versions. Two consequences follow: - The repository-wide Apache RAT check is bound to the `verify` phase of the root reactor, which never includes this module. - The dedicated `backwards_compatibility.yml` workflow runs `mvn ... test` inside the module directory, which stops before the `verify` phase where RAT runs. So neither path exercises RAT on these two files. ## Brief change log - Add the standard ASF license header to `pom.xml` and `DynamicTableSourceTest.java`, byte-identical to the header already present on the module's sibling files. ## Verifying this change License-header-only change; no production or test logic is touched. Verified locally that `mvn apache-rat:check` reports both files as `AL` (approved license) after the change; before the change they were flagged as unapproved. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
