raminqaf opened a new pull request, #28684:
URL: https://github.com/apache/flink/pull/28684

   ## What is the purpose of the change                                         
                                                                                
                                           
                                                                                
                                                                                
                                           
   Consolidates the `CREATE`/`REPLACE TABLE AS SELECT` EXPLAIN tests into the 
dedicated `ExplainTest`, next to the other `.out`-based explain goldens. This 
is a test-only cleanup, no production code  changes. This is a follow-up PR on: 
https://issues.apache.org/jira/browse/FLINK-40039                               
                                                                                
                                                                               
                                                                                
                                                                                
                                           
   ## Brief change log                                                          
                                                                                
                                           
                                                                                
                                                                                
                                           
     - Moved the four CTAS/RTAS explain tests from `TableSinkTest` (Scala) to 
`ExplainTest` (Java)                                                            
                                             
     - Added a `verifyExplain(statement, goldenName)` overload so REPLACE can 
reuse the CTAS golden                                                           
                                             
     - Regenerated the two goldens: `MyTable` is a `values` source in 
`ExplainTest`, so the scan node changes from `DataStreamScan` to 
`TableSourceScan` (AST unchanged)                                   
                                                                                
                                                                                
                                           
   ## Verifying this change                                                     
                                                                                
                                           
                                                                                
                                                                                
                                           
   This change is a test-only rework. It is covered by the moved tests in 
`ExplainTest`, verified with `mvn test -pl flink-table/flink-table-planner 
-Dtest=ExplainTest`.                                  
                                                                                
                                                                                
                                           
   ## Does this pull request potentially affect one of the following parts:     
                                                                                
                                           
                                                                                
                                                                                
                                           
     - Dependencies (does it add or upgrade a dependency): no                   
                                                                                
                                           
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no                                                         
                                                          
     - The serializers: no                                                      
                                                                                
                                           
     - The runtime per-record code paths (performance sensitive): no            
                                                                                
                                           
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no                      
                                                  
     - The S3 file system connector: no                                         
                                                                                
                                           
                                                                                
                                                                                
                                           
   ## Documentation                                                             
                                                                                
                                           
                                                                                
                                                                                
                                           
     - Does this pull request introduce a new feature? no                       
                                                                                
                                           
     - If yes, how is the feature documented? not applicable  
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, 
please
   change the checkbox below to `[X]` followed by the name of the tool, and 
uncomment the
   "Generated-by" line. See the ASF Generative Tooling Guidance for details:
   https://www.apache.org/legal/generative-tooling.html
   
   You are responsible for the quality and correctness of every change in this 
PR
   regardless of the tooling used. Low-effort AI-generated PRs will be closed. 
See
   AGENTS.md for the full guidance.
   -->
   
   - [X] Yes (please specify the tool below)
   
   
   Generated-by: Opus 4.8
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to