Dennis-Mircea commented on code in PR #1152:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1152#discussion_r3542305511
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/kubeclient/decorators/FlinkConfMountDecorator.java:
##########
@@ -234,17 +234,20 @@ public String getFlinkConfFilename() {
return useStandardYamlConfig() ? "config.yaml" : "flink-conf.yaml";
}
+ boolean useStandardYamlConfig() {
Review Comment:
I'd say we can stick to only one useStandardYamlConfig method, the one from
below.
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java:
##########
@@ -1043,19 +1044,35 @@ protected Duration deleteDeploymentBlocking(
@VisibleForTesting
protected static Configuration removeOperatorConfigs(Configuration config)
{
- Configuration newConfig = new Configuration();
- config.toMap()
- .forEach(
- (k, v) -> {
- if (!k.startsWith(K8S_OP_CONF_PREFIX)
- &&
!k.startsWith(AutoScalerOptions.AUTOSCALER_CONF_PREFIX)) {
- newConfig.setString(k, v);
- }
- });
-
+ // Copy and remove keys directly: a toMap() round-trip would serialize
values (e.g. the
+ // list-typed pipeline.jars) in the operator's own YAML dialect, which
the target Flink
+ // version may not parse. Raw values let the write boundaries render
per target version.
Review Comment:
Bettert to create a method JavaDoc instead of having this long inline
comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
