raminqaf commented on code in PR #28682: URL: https://github.com/apache/flink/pull/28682#discussion_r3542949819
########## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/CalcTest.scala: ########## Review Comment: nit: this only exercises the legacy group-window representation (`GROUP BY TUMBLE(...) → LogicalWindowAggregate)`. The windowing-TVF form (`FROM TABLE(TUMBLE(...)) + GROUP BY window_start, window_end`) stays a plain `LogicalAggregate` at this stage and is already covered by `AGGREGATE_INSTANCE`. Could you add one TVF-window case so both representations are pinned by a test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
