yuxiqian commented on code in PR #4466:
URL: https://github.com/apache/flink-cdc/pull/4466#discussion_r3548543462
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/source/reader/MySqlPipelineRecordEmitter.java:
##########
@@ -130,11 +140,13 @@ public void applySplit(MySqlSplit split) {
protected void processElement(
SourceRecord element, SourceOutput<Event> output, MySqlSplitState
splitState)
throws Exception {
- if (shouldEmitAllCreateTableEventsInSnapshotMode && isBounded) {
- // In snapshot mode, we simply emit all schemas at once.
+ if (shouldEmitAllCreateTableEventsInSnapshotMode
+ && shouldBatchEmitCreateTableEvents()) {
+ // In snapshot mode or batch emit mode, we emit all schemas at
once.
Review Comment:
IIUC `CreateTableEvent`s are still emitted one-by-one with this option
enabled, and lots of schema coordination might block job from starting up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
