Samrat002 commented on code in PR #28136:
URL: https://github.com/apache/flink/pull/28136#discussion_r3549171693
##########
flink-filesystems/flink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/S3ClientProvider.java:
##########
@@ -295,17 +365,21 @@ public CompletableFuture<Void> closeAsync() {
} catch (Exception e) {
LOG.warn("Error closing S3 TransferManager",
e);
}
+ try {
+ asyncClient.close();
+ } catch (Exception e) {
+ LOG.warn("Error closing S3 async client", e);
+ }
try {
s3Client.close();
} catch (Exception e) {
LOG.warn("Error closing S3 sync client", e);
}
- if (getCredentialsProvider() instanceof
SdkAutoCloseable) {
- try {
- ((SdkAutoCloseable)
getCredentialsProvider()).close();
- } catch (Exception e) {
- LOG.warn("Error closing credentials
provider", e);
- }
+ closeCredentialsProviderQuietly(
+ credentialsProvider, "credentials
provider");
+ if (baseCredentialsProvider !=
credentialsProvider) {
+ closeCredentialsProviderQuietly(
+ baseCredentialsProvider, "base
credentials provider");
Review Comment:
My bad. A few custom changes that are not required. reverted it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
