swatiksi273-ksolves commented on code in PR #1139:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1139#discussion_r3549325728
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/metrics/ScalingMetrics.java:
##########
@@ -83,6 +83,15 @@ public static void computeDataRateMetrics(
var isSource = topology.isSource(jobVertexID);
var ioMetrics = topology.get(jobVertexID).getIoMetrics();
+ if (!ioMetrics.isMetricsComplete()) {
+ LOG.warn(
+ "Incomplete IO metrics for vertex {}, skipping scaling
decision to avoid incorrect scale down.",
+ jobVertexID);
+ scalingMetrics.put(ScalingMetric.NUM_RECORDS_IN, Double.NaN);
+ scalingMetrics.put(ScalingMetric.NUM_RECORDS_OUT, Double.NaN);
Review Comment:
Hi @Dennis-Mircea,
Just wanted to gently ping this thread. The fix has been isolated strictly
to ScalingMetricCollector.java based on your previous feedback, and cluster
testing on minikube confirms the behavior.
Whenever you have a moment, could you please take a look? Let me know if you
need any further changes or clarifications before this is ready to merge.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
