Dennis-Mircea opened a new pull request, #1158:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1158
## What is the purpose of the change
The parent `pom.xml` lists the four example modules individually next to the
core modules. This groups them under a dedicated `examples` aggregator pom, so
the parent references a single `examples` module and the aggregator owns the
example list and their shared configuration. This mirrors Apache Flink's own
`flink-examples` aggregator.
## Brief change log
- Add `examples/pom.xml`, a `pom`-packaged aggregator module:
- Parent: `flink-kubernetes-operator-parent` (`relativePath ..`),
artifactId `flink-kubernetes-operator-examples`.
- `modules`: `autoscaling`, `flink-beam-example`,
`flink-sql-runner-example`, `kubernetes-client-examples`.
- `properties`: `maven.deploy.skip=true`, hoisted from the individual
example poms so it is defined once and also skips deploy of the aggregator
itself.
- Parent `pom.xml`: replace the four `examples/...` module entries with a
single `<module>examples</module>` (core module list unchanged).
- Each example pom (`autoscaling`, `flink-beam-example`,
`flink-sql-runner-example`, `kubernetes-client-examples`):
- Change `<parent>` from `flink-kubernetes-operator-parent` (`relativePath
../..`) to `flink-kubernetes-operator-examples` (`relativePath ..`).
- Remove the now-inherited `maven.deploy.skip` property.
Because the aggregator's parent is the root parent, the examples still
inherit all managed dependencies, plugin configuration, and properties (e.g.
`flink.version`) transitively, so no example dependency or build config changes.
## Verifying this change
- `mvn clean install -DskipTests` builds successfully with the examples now
nested under the `examples` aggregator, and the reactor still builds all four
examples.
- Confirm `maven.deploy.skip` is still in effect for every example (no
example artifact is deployed).
- The XML format check (`sortpom`) passes for the new and modified poms.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changes to the `CustomResourceDescriptors`:
no
- Core observer or reconciler logic that is regularly executed: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
