Olawoyin007 commented on code in PR #888:
URL: https://github.com/apache/flink-agents/pull/888#discussion_r3557803789
##########
tools/install.sh:
##########
@@ -1576,7 +1586,7 @@ validate_python_bin() {
py_major="${py_version_output%%.*}"
py_minor="${py_version_output##*.}"
- if [[ "$py_major" -ne 3 ]] || [[ "$py_minor" -lt 10 ]] || [[ "$py_minor"
-ge 12 ]]; then
+ if [[ "$py_major" -ne 3 ]] || [[ "$py_minor" -lt 10 ]] || [[ "$py_minor"
-ge "$(python_minor_ceiling)" ]]; then
Review Comment:
Good catch - fixed in c4f81b4. The `flink_agents_version)` arm now calls a
new `revalidate_python_for_agents_version` after the version prompt: if PyFlink
is enabled and the already-resolved `PYTHON_BIN` no longer satisfies the new
release's ceiling, it warns and re-runs `resolve_python` (same semantics as the
`enable_pyflink)` arm - and since `PYTHON_BIN` is part of the edit-state dump,
the re-resolved interpreter propagates back to the plan). Your exact scenario
(3.12 accepted under 0.3.0, then edited down to 0.2.1) is covered by a new bats
test, plus four more for the keep/no-op paths.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
