Au-Miner commented on code in PR #28681: URL: https://github.com/apache/flink/pull/28681#discussion_r3557828248
########## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/hints/batch/JoinHintTestBase.java: ########## @@ -51,9 +51,6 @@ * A test base for join hint. * * <p>TODO add test to cover legacy table source. - * Review Comment: Now both ast and optimize rel plan can correctly display different joinHints. Take testJoinHintsInNestedRexSubQUERY as an example, | XML File | Outer Subquery Hint | Inner Subquery Hint | |---|---|---| | `BroadcastJoinHintTest.xml` | `BROADCAST(T2)` | `SHUFFLE_HASH(T1)` | | `ShuffleHashJoinHintTest.xml` | `SHUFFLE_HASH(T2)` | `BROADCAST(T1)` | | `ShuffleMergeJoinHintTest.xml` | `SHUFFLE_MERGE(T2)` | `BROADCAST(T1)` | | `NestLoopJoinHintTest.xml` | `NEST_LOOP(T2)` | `BROADCAST(T1)` | | `QueryHintsResolverTest.xml` | `BROADCAST(T2)` | `SHUFFLE_HASH(T1)` | | `ClearQueryBlockAliasResolverTest.xml` | `BROADCAST(T2)` | `SHUFFLE_HASH(T1)` | Take testJoinHintWithDifferentHintsInSiblingSubQueries as an example, | XML File | First Sibling Hint | Second Sibling Hint | |---|---|---| | `BroadcastJoinHintTest.xml` | `BROADCAST(T2)` | `SHUFFLE_HASH(T1)` | | `ShuffleHashJoinHintTest.xml` | `SHUFFLE_HASH(T2)` | `BROADCAST(T1)` | | `ShuffleMergeJoinHintTest.xml` | `SHUFFLE_MERGE(T2)` | `BROADCAST(T1)` | | `NestLoopJoinHintTest.xml` | `NEST_LOOP(T2)` | `BROADCAST(T1)` | | `QueryHintsResolverTest.xml` | `BROADCAST(T2)` | `SHUFFLE_HASH(T1)` | | `ClearQueryBlockAliasResolverTest.xml` | `BROADCAST(T2)` | `SHUFFLE_HASH(T1)` | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
