spuru9 commented on PR #28610:
URL: https://github.com/apache/flink/pull/28610#issuecomment-4935402593
Thanks for the detailed review, @MartijnVisser! Addressed everything:
- Rebased onto `master` (was only 1 commit behind effectively; resolved a
`package-lock.json` conflict by regenerating via `npm install` — `dependencies`
block still byte-identical to `master`).
- Dropped the unused `@types/jasmine` / `@types/jasminewd2`.
- Simplified the job-exceptions "location cell" spec to call
`navigateTo('tm-1')` directly instead of clicking through the lazy tab.
- Verified the production build behind a real running JobManager (not just
`ng build` exit code): started a local cluster, served the new build output,
and drove Overview / Task Managers / Job Exceptions with Playwright — including
forcing a real TaskManager-loss exception to exercise the Exception History tab
and the location-cell → TaskManager-metrics navigation. All rendered correctly
with zero console errors.
- On scope: confirmed FLINK-40033 covers only the 3 viz-library bumps, not
the builder migration, so recording it on FLINK-40035 (as the changelog already
does) is correct.
Force-pushed the rebase — PR shows clean/mergeable now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
