[ 
https://issues.apache.org/jira/browse/FLINK-40118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Purushottam Sinha updated FLINK-40118:
--------------------------------------
    Description: 
Problem                                                                         
                                                                                
                                               
  The job Timeline tab's SubTask view labels each subtask bar 0 - undefined, 1 
- undefined, etc. instead of showing the host/endpoint the subtask ran on. 
                                                                                
                            
Evidence                                                                        
                                                                                
                                               
  - 
flink-runtime-web/web-dashboard/src/app/pages/job/timeline/job-timeline.component.ts:135,141
 builds the label as `${task.subtask} - ${task.host}`                           
                                 
  - src/app/interfaces/job-timeline.ts:25 still declares the field as host: 
string, so TypeScript compiles clean while task.host is undefined at runtime    
                                                     
  - Root cause is backend/frontend drift, not a day-one bug: host was valid 
when the dashboard was built in 2019 (dcd92958c58c). PR apache/flink#23465 
(FLINK-33147, 2023-11-09) added endpoint alongside host, deprecating the 
latter. PR apache/flink#25436 (FLINK-36355, merged 2024-10-01, commit 
0b4de216d98 "Remove deprecated host") then deleted host from the REST response 
entirely — that PR touched only backend Java classes and never updated the 
Angular frontend, so task.host has read undefined ever since                    
                                                                                
            
  - Confirmed still present on current master                                   
                                                                                
                                                 
                                                                                
                                                                                
                                                 
Proposed fix                                                                    
                                                                                
                                               
  - job-timeline.ts:25: host: string → endpoint: string                         
                                                                                
                                                 
  - job-timeline.component.ts:135,141: ${task.host} → ${task.endpoint}          
                                                                                
                                                 
                                                                                
                                                                                
                                                 
Acceptance                                                                      
                                                                                
                                               
  - SubTask TimeLine bars for a running job read N - localhost:PORT instead of 
N - undefined

  was:
Problem                                                                         
                                                                                
                                               
  The job Timeline tab's SubTask view labels each subtask bar 0 - undefined, 1 
- undefined, etc. instead of showing the host/endpoint the subtask ran on. 
                                                                                
                            
Evidence                                                                        
                                                                                
                                               
  - 
flink-runtime-web/web-dashboard/src/app/pages/job/timeline/job-timeline.component.ts:135,141
 builds the label as `${task.subtask} - ${task.host}`                           
                                 
  - src/app/interfaces/job-timeline.ts:25 still declares the field as host: 
string, so TypeScript compiles clean while task.host is undefined at runtime    
                                                     
  - Root cause is backend/frontend drift, not a day-one bug: host was valid 
when the dashboard was built in 2019 (dcd92958c58c). PR apache/flink#23465 
(FLINK-33147, 2023-11-09) added endpoint alongside host, deprecating the 
latter. PR apache/flink#25436 (FLINK-36355, merged 2024-10-01, commit 
0b4de216d98 "Remove deprecated host") then deleted host from the REST response 
entirely — that PR touched only backend Java classes and never updated the 
Angular frontend, so task.host has read undefined ever since                    
                                                                                
            
  - Confirmed still present on current master                                   
                                                                                
                                                 
                                                                                
                                                                                
                                                 
Proposed fix                                                                    
                                                                                
                                               
  - job-timeline.ts:25: host: string → endpoint: string                         
                                                                                
                                                 
  - job-timeline.component.ts:135,141: ${task.host} → ${task.endpoint}          
                                                                                
                                                 
                                                                                
                                                                                
                                                 
Acceptance                                                                      
                                                                                
                                               
  - SubTask TimeLine bars for a running job read N - localhost:PORT instead of 
N - undefined
 !screenshot-1.png! 


> Web dashboard: SubTask TimeLine shows "N - undefined" instead of the task 
> endpoint
> ----------------------------------------------------------------------------------
>
>                 Key: FLINK-40118
>                 URL: https://issues.apache.org/jira/browse/FLINK-40118
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / Web Frontend
>            Reporter: Purushottam Sinha
>            Priority: Minor
>         Attachments: screenshot-1.png
>
>
> Problem                                                                       
>                                                                               
>                                                    
>   The job Timeline tab's SubTask view labels each subtask bar 0 - undefined, 
> 1 - undefined, etc. instead of showing the host/endpoint the subtask ran on. 
>                                                                               
>                               
> Evidence                                                                      
>                                                                               
>                                                    
>   - 
> flink-runtime-web/web-dashboard/src/app/pages/job/timeline/job-timeline.component.ts:135,141
>  builds the label as `${task.subtask} - ${task.host}`                         
>                                    
>   - src/app/interfaces/job-timeline.ts:25 still declares the field as host: 
> string, so TypeScript compiles clean while task.host is undefined at runtime  
>                                                        
>   - Root cause is backend/frontend drift, not a day-one bug: host was valid 
> when the dashboard was built in 2019 (dcd92958c58c). PR apache/flink#23465 
> (FLINK-33147, 2023-11-09) added endpoint alongside host, deprecating the 
> latter. PR apache/flink#25436 (FLINK-36355, merged 2024-10-01, commit 
> 0b4de216d98 "Remove deprecated host") then deleted host from the REST 
> response entirely — that PR touched only backend Java classes and never 
> updated the Angular frontend, so task.host has read undefined ever since      
>                                                                               
>                             
>   - Confirmed still present on current master                                 
>                                                                               
>                                                      
>                                                                               
>                                                                               
>                                                      
> Proposed fix                                                                  
>                                                                               
>                                                    
>   - job-timeline.ts:25: host: string → endpoint: string                       
>                                                                               
>                                                      
>   - job-timeline.component.ts:135,141: ${task.host} → ${task.endpoint}        
>                                                                               
>                                                      
>                                                                               
>                                                                               
>                                                      
> Acceptance                                                                    
>                                                                               
>                                                    
>   - SubTask TimeLine bars for a running job read N - localhost:PORT instead 
> of N - undefined



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to