fqshopify opened a new pull request, #1159: URL: https://github.com/apache/flink-kubernetes-operator/pull/1159
## What is the purpose of the change When a Blue/Green transition is aborted, `abortDeployment` rolled the state back to `ACTIVE_BLUE` but left `deploymentReadyTimestamp` set to the value from the aborted transition (only the finalize paths reset it). On the **next** deployment, the delete-Blue gate in `shouldWeDelete` computes `deletionTimestamp = staleReadyTimestamp + deletionDelay`, which is already in the past, so Blue is deleted the instant Green first reports `RUNNING` - skipping the deletion delay entirely and causing downtime. This pull request makes `abortDeployment` reset the transition markers the same way the finalize paths do, so a redeploy after an abort re-arms the delete-Blue deletion delay from scratch. ## Brief change log - `abortDeployment` now resets `deploymentReadyTimestamp` to 0 on abort, so the next transition re-arms the delete-Blue delay instead of treating it as long expired. - `abortDeployment` now also resets `abortTimestamp` to 0, making the abort teardown symmetric with `finalizeBlueGreenDeployment` / `finalizeSuspendedDeployment` (which already reset `deploymentReadyTimestamp`, `abortTimestamp`, and `savepointTriggerId`). - Added a regression test exercising the full abort => redeploy lifecycle in `SAVEPOINT` upgrade mode. ## Verifying this change This change added tests and can be verified using `mvn clean verify` ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): **no** - The public API, i.e., is any changes to the `CustomResourceDescriptors`: **no** - Core observer or reconciler logic that is regularly executed: **yes** (the Blue/Green abort path in the reconciler) ## Documentation - Does this pull request introduce a new feature? **no** - If yes, how is the feature documented? **not applicable** (bug fix) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
