weiqingy commented on PR #879:
URL: https://github.com/apache/flink-agents/pull/879#issuecomment-4942968812
Thanks for the update. LGTM. I'll leave the final merge call to @wenjin272.
One optional, non-blocking thought on the new Javadoc block: the last line
reads a little rough (`the initialArguments should put ("pythonClazz", ...)`),
and it doesn't say what `clazz` should be in this case. Since
`PythonResourceProvider.provide()` rebuilds the module and class from
`pythonClazz` whenever `module` is empty, `clazz` is effectively ignored on
this path — the new tests just pass a placeholder. Might be worth spelling that
out, e.g.:
> For Python resources (when declaring from Java): put the fully-qualified
Python class under the `pythonClazz` key in `initialArguments` (e.g.
`("pythonClazz", "your_module.submodule.YourPythonClass")`). The `clazz`
argument is unused in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
