spuru9 opened a new pull request, #210: URL: https://github.com/apache/flink-connector-jdbc/pull/210
## What is the purpose of the change 37 files across the repo are missing the ASF license header required on every source file, despite `apache-rat-plugin` being configured in the build. None are new — every flagged file traces back to 2024, predating v4.0.0's actual release. Running `org.apache.rat:apache-rat-plugin:check` per module against current `main` (not just grepping) finds headers missing in: - 27 Java files in `flink-connector-jdbc-core` (XA transaction classes, `JdbcCatalog`, `FilterHandlingPolicy`, `JdbcCommitter`/`JdbcCommitable`, and their tests) - `flink-connector-jdbc-db2`'s `pom.xml` and `Db2Images.java` - `pom.xml` in 7 other vendor modules (cratedb, mysql, oceanbase, oracle, postgres, sqlserver, trino) plus `flink-connector-jdbc-architecture` ## Why it isn't caught by CI The root pom's `apache-rat-plugin` declares `<inherited>false</inherited>`, which stops its `<configuration>` (the excludes list) from cascading to submodules, and its `verify`-bound execution never actually fires during a normal build anyway (confirmed against a live CI run). That's a separate, deeper gap — tracked in FLINK-40127 for follow-up, not part of this change, to keep this PR a pure content fix. ## Brief change log - Add the standard ASF license header to the 37 files identified above, byte-identical to the header already present on their sibling files. ## Verifying this change License-header-only change; no production or test logic touched. Verified locally that each affected module passes `org.apache.rat:apache-rat-plugin:check` for the files touched, and that `flink-connector-jdbc-core` and `flink-connector-jdbc-db2` (the two modules with actual `.java` changes) still compile cleanly. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
