spuru9 commented on code in PR #285:
URL: 
https://github.com/apache/flink-connector-kafka/pull/285#discussion_r3566366950


##########
flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/dynamic/source/enumerator/DynamicKafkaSourceEnumeratorTest.java:
##########
@@ -2440,6 +2441,13 @@ private boolean hasLatestMetadataUpdateEvent(
                     .equals(Collections.singleton(expectedKafkaStream));
         } catch (AssertionError e) {
             return false;
+        } catch (ConcurrentModificationException e) {

Review Comment:
   Might just be one multi-catch instead of duplicating return false.
   
   ```suggestion
           } catch (AssertionError | ConcurrentModificationException e) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to