wenjin272 commented on issue #894: URL: https://github.com/apache/flink-agents/issues/894#issuecomment-4955998292
@weiqingy Overall, I agree with your point of view. 1. We definitely need to verify the accuracy of `AGENTS.md`. 2. I think adding specific cases is reasonable. However, I have two concerns: first, whether these examples are representative; second, how to keep `code_review.md` concise to avoid consuming excessive context window space. Regarding other items worth discussing: > A change-type review matrix (e.g. api/ contract changes, runtime/ state or recovery changes, Python-Java bridge changes, dist/dependency changes, docs-only changes) mapping each PR type to the passes that matter most, as an on-ramp into the existing full checklist. This seems very meaningful as it makes the injected context more focused and concise. > Whether module-scoped AGENTS.md files (e.g. under python/, runtime/python/, dist/) would help, given how differently those sub-domains behave. This feels reasonable personally, but we might want to observe if other repos have similar practices. > Whether CLAUDE.md and AGENTS.md should converge toward one source of truth with a thin pointer from the other, to avoid the two guides drifting. Could we use a symlink to point CLAUDE.md directly to AGENTS.md? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
