XComp commented on code in PR #28633:
URL: https://github.com/apache/flink/pull/28633#discussion_r3580280388
##########
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/timeline/RescaleTimelineITCase.java:
##########
@@ -269,15 +269,24 @@ void testRescaleTerminatedBySucceeded() {}
@TestTemplate
void testRescaleTerminatedByJobFinished() throws Exception {
+ // This case only asserts on the recorded rescale history; skip the
disabled-history
+ // parameter before the cluster rebuild below so it does not pay for
an unused cluster.
+ assumeThat(enabledRescaleHistory(configuration)).isTrue();
Review Comment:
It's kind of odd that we use `@TestTemplate` when we only want to run one
option. Instead of using assume here, we could just run it as a @Test with the
rescale history enabled.
Especially since we're rebuilding the Flink cluster within the test anyway
with custom configuration.
But it is not that straight-forward. So it might be a follow-up ticket. We
would improve the test runtime because we skip unnecessary MiniCluster startups
not only in this test but also the other tests that use assume similarly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
