Zhuoxi2000 commented on issue #907:
URL: https://github.com/apache/flink-agents/issues/907#issuecomment-4976711558

   > Thanks for reporting this. I confirmed the issue on the current main 
branch. Since the Java implementation applies `String.replace` sequentially, 
placeholders introduced by an earlier substitution may be expanded by a later 
one, making the result dependent on the map iteration order. The native Python 
formatter performs a single-pass substitution and is not affected.
   > 
   > I think that the Java implementation should only scan placeholders from 
the original template, with regression coverage for both `formatString` and 
`formatMessages`.
   > 
   > Thanks for indicating that you’re willing to submit a PR, I’ve assigned 
the issue to you. Please let us know if you have any questions along the way.
   
   Thanks for confirming and the assignment. added regression coverage for both 
paths as you suggested


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to