wenjin272 commented on code in PR #898:
URL: https://github.com/apache/flink-agents/pull/898#discussion_r3585466817
##########
docs/content/docs/development/chat_models.md:
##########
@@ -643,6 +643,98 @@ Some popular options include:
Model availability depends on your Azure region and subscription. Always check
the official Azure OpenAI documentation for regional availability before
implementing in production.
{{< /hint >}}
+### Gemini
+
+Google Gemini provides cloud-based chat models through the Gemini Developer
API and Vertex AI. The Flink Agents Gemini integration uses the official Google
Gen AI SDK and supports text conversations, system instructions, and tool
calling.
Review Comment:
This section explicitly presents Vertex AI as a supported backend, but the
code comment in `GeminiChatModelConnection` notes:
`“The Vertex path wires the SDK builder flags and is smoke-tested at
construction, but a full end-to-end run against Vertex is a follow-up.” `
Has the Vertex AI path been manually verified since then? If not, I suggest
clearly marking Vertex AI as experimental and not yet end-to-end verified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
