Savonitar commented on code in PR #28709:
URL: https://github.com/apache/flink/pull/28709#discussion_r3585811735
##########
flink-libraries/flink-state-processing-api/src/test/java/org/apache/flink/state/api/SavepointDeepCopyTest.java:
##########
@@ -173,7 +173,7 @@ public void testSavepointDeepCopy() throws Exception {
.write(savepointPath2);
env.execute("create savepoint2");
- Set<String> stateFiles2 =
getFileNamesInDirectory(Paths.get(savepointPath1));
+ Set<String> stateFiles2 =
getFileNamesInDirectory(Paths.get(savepointPath2));
Review Comment:
No, this one is independent, that's why it is in the separate hotfix commit.
stateFiles2 was read from savepointPath1, so both assertions compared
savepoint1's file listing with itself and the "savepoint2 contains the copied
files" property was never actually checked.
I found it while working on the main commit. it does not reproduce the
CLAIM-restore bug, but helps with its testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
