autophagy commented on code in PR #28657:
URL: https://github.com/apache/flink/pull/28657#discussion_r3586067195
##########
flink-table/flink-table-test-utils/src/main/java/org/apache/flink/table/runtime/functions/ProcessTableFunctionTestHarness.java:
##########
@@ -163,9 +172,28 @@ private ProcessTableFunctionTestHarness(
this.arguments = arguments;
this.argumentConverters = argumentConverters;
this.harnessOutputConverter = harnessOutputConverter;
+ this.outputIsAtomic =
!LogicalTypeChecks.isCompositeType(ptfOutputType.getLogicalType());
+ this.outputIsRow = ptfOutputType.getLogicalType() instanceof RowType;
+ DataStructureConverter<Object, Object> compositeOutputToInternal =
null;
+ DataStructureConverter<Object, Object> compositeOutputToRow = null;
Review Comment:
Yeah, good call, probably nicer to not have these and just have explicit
else branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
