spuru9 commented on PR #28710: URL: https://github.com/apache/flink/pull/28710#issuecomment-4984629581
Thanks for the thorough review @MartijnVisser! Both addressed: **1. Commit split.** Done — force-pushed as two commits: - `[FLINK-40034][runtime-web] Bump prettier to 3, eslint-plugin-prettier to 5, stylelint to 17` — the dependency cascade + `.stylelintrc.js` config only. - `[FLINK-40034][runtime-web] Apply prettier 3 / stylelint 17 formatting fixes` — the mechanical `lint:fix` output, so it's easy to skim past. **2. `color-function-alias-notation`.** Good call to keep the guard on. One small correction: `'legacy'` isn't a valid value for this rule — that's the option for the separate `color-function-notation` rule. This rule's options are `'with-alpha'` / `'without-alpha'` (config-standard 40 defaults to `'without-alpha'`, which is the alpha-dropping direction). The rgba-preserving value is `'with-alpha'`, so I've set that. Verified with stylelint 17.14.0: - `npm run lint` passes clean — `'with-alpha'` does **not** flag the existing `rgba()` usages in `app.component.less` (x2), `dagre.component.less`, or `styles/index.less`, and doesn't misfire on Less the way the two `declaration-property-value-*` rules do. - The guard is live: linting a scratch rule with `color: rgb(0, 0, 0, 0.8); background: hsl(0, 0%, 0%, 0.5);` flags both, and `--fix` rewrites them to the Less-safe `rgba(0, 0, 0, 0.8)` / `hsla(...)` — exactly the alpha-dropping form we want to catch. - `lint:fix` under the final config produces no new source changes. Description updated to match on both points. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
