davidradl commented on code in PR #53: URL: https://github.com/apache/flink-connector-http/pull/53#discussion_r3594821280
##########
docs/content.zh/docs/connectors/table/http.md:
##########
@@ -250,7 +250,7 @@ Note the options with the prefix _http_ are the HTTP
connector specific options,
| connector |
required | The Value should be set to _http_
|
| format |
required | Flink's format name that should be used to decode REST response, Use
`json` for a typical REST endpoint.
|
| url |
required | The base URL that should be used for GET requests. For example
_http://localhost:8080/client_
|
-| asyncPolling |
optional | true/false - determines whether Async Polling should be used.
Mechanism is based on Flink's Async I/O.
|
+| async-polling |
optional | true/false - determines whether async polling should be used.
Mechanism is based on Flink's Async I/O. Deprecated alias: `asyncPolling`.
|
Review Comment:
now we have release we cannot easily change a config name . We would need to
deprecate but keep the old property and indicate people should use the new
property name in preference. So we need to keep the docs for asyncPolling and
still accept that property. We probably need some validation to reject configs
with both keys set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
