snuyanzin commented on code in PR #28765:
URL: https://github.com/apache/flink/pull/28765#discussion_r3601334560
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/CodeGenUtils.scala:
##########
@@ -233,12 +233,14 @@ object CodeGenUtils {
value match {
case JFloat.NEGATIVE_INFINITY => "java.lang.Float.NEGATIVE_INFINITY"
case JFloat.POSITIVE_INFINITY => "java.lang.Float.POSITIVE_INFINITY"
+ case f: JFloat if f.isNaN => "java.lang.Float.NaN"
Review Comment:
why not
```scala
case JFloat.NaN => "java.lang.Float.POSITIVE_INFINITY"
```
?
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/CodeGenUtils.scala:
##########
@@ -233,12 +233,14 @@ object CodeGenUtils {
value match {
case JFloat.NEGATIVE_INFINITY => "java.lang.Float.NEGATIVE_INFINITY"
case JFloat.POSITIVE_INFINITY => "java.lang.Float.POSITIVE_INFINITY"
+ case f: JFloat if f.isNaN => "java.lang.Float.NaN"
Review Comment:
why not
```scala
case JFloat.NaN => "java.lang.Float.NaN"
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
